feat: add emission event example, and add lifetime to state from fpbase, test examples #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 79.30% 79.31% +0.01%
==========================================
Files 38 38
Lines 1696 1697 +1
==========================================
+ Hits 1345 1346 +1
Misses 351 351 ☔ View full report in Codecov by Sentry. |
ashesh-0
added a commit
to ashesh-0/microsim
that referenced
this pull request
May 19, 2024
tlambert03
added a commit
that referenced
this pull request
Jun 16, 2024
* added TODO comments * interval creation+stochastic excitation model * comment update * interval creation made disjoint with 1 test * style(pre-commit.ci): auto fixes [...] * fix in test+ comment updates * style(pre-commit.ci): auto fixes [...] * changes made inspired from the discussion at #34 * renamed spectrum to avoid conflict * style(pre-commit.ci): auto fixes [...] * replaced Interval class with a function * style(pre-commit.ci): auto fixes [...] * fixing the peak_wavelength attribute logic * style(pre-commit.ci): auto fixes [...] * fixing type errors * line length <88 * serializable numpy * remove serializable_numpy.py * bin based setup now working * bin based setup now working * rough changes to make it work * multi channel confocal example * removed duplicated spectrum() function * emission flux. WIP for optical image * multi-fluorophore setup code running * style(pre-commit.ci): auto fixes [...] * multi-fluorophore setup code running * style(pre-commit.ci): auto fixes [...] * removed comments * removed a fn * removed a fn * style(pre-commit.ci): auto fixes [...] * undo channel_idx removal * merge results in run * a number of suggestions * minor refactoring * minor refactoring * refactoring * making tests work * typing improvements --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Talley Lambert <talley.lambert@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds the code I put in #33 (comment) into an example, so we don't lose it, until it gets integrated. And also pulls lifetime from fpbase
this also adds a
test_examplestest to make sure that all examples are still runnable