Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: higher level psf caching #28

Merged
merged 5 commits into from
May 7, 2024
Merged

feat: higher level psf caching #28

merged 5 commits into from
May 7, 2024

Conversation

tlambert03
Copy link
Owner

this caches PSFs at a slightly higher level (make_psf) which will also include the convolution done when making a confocal psf. In order to do say, it makes NumpyAPI hashable in a way that may possible be troublesome later, but we'll cross that bridge when we come to it

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (5acbbb1) to head (daedf0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   78.87%   78.99%   +0.11%     
==========================================
  Files          36       36              
  Lines        1619     1628       +9     
==========================================
+ Hits         1277     1286       +9     
  Misses        342      342              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit c6d9c8d into main May 7, 2024
17 checks passed
@tlambert03 tlambert03 deleted the morecache branch May 7, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant