Skip to content

Commit

Permalink
test: configure test project to not run twice
Browse files Browse the repository at this point in the history
Some tests had been configured in a way that they had both the extension
as well as an explicit call to the plugin. Which resulted the plugin
running twice, one time with the default configuration. Another time
with the explicit configuration.

This results in the RPM file being created twice. But in the case of the
"forcerelease" test, with too different output file names.

This change configures the test project correctly, so that there is no
explicit invocation of the plugin, only the configuration of the
implicit step, triggered by enabling the plugin as an extension.

closes ctron#63
  • Loading branch information
ctron committed Apr 6, 2022
1 parent b51924f commit 4092cab
Showing 1 changed file with 13 additions and 21 deletions.
34 changes: 13 additions & 21 deletions src/it/test14-forcerelease/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,29 +43,21 @@
<artifactId>rpm</artifactId>
<extensions>true</extensions>
<version>@project.version@</version>
<executions>
<execution>
<goals>
<goal>rpm</goal>
</goals>
<configuration>
<group>Application/Misc</group>
<configuration>
<group>Application/Misc</group>

<forceRelease>true</forceRelease>
<snapshotVersion>1.2.3</snapshotVersion>
<version>4.5.6</version>
<forceRelease>true</forceRelease>
<snapshotVersion>1.2.3</snapshotVersion>
<version>4.5.6</version>

<signature>
<keyId>${keyId}</keyId>
<keyringFile>${user.home}/.gnupg/secring.gpg</keyringFile>
<passphrase>${passphrase}</passphrase>
<hashAlgorithm>SHA1</hashAlgorithm>
<skip>${skipSigning}</skip>
</signature>

</configuration>
</execution>
</executions>
<signature>
<keyId>${keyId}</keyId>
<keyringFile>${user.home}/.gnupg/secring.gpg</keyringFile>
<passphrase>${passphrase}</passphrase>
<hashAlgorithm>SHA1</hashAlgorithm>
<skip>${skipSigning}</skip>
</signature>
</configuration>
</plugin>
</plugins>
</build>
Expand Down

0 comments on commit 4092cab

Please sign in to comment.