Set opt-out flag for Rust crates to prevent accidental publishing #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-n-o
approved these changes
Nov 30, 2023
9346dae to
691f9c1
Compare
|
I initially missed two cases. |
|
@r-n-o : does the additional change look good to you? Given the context, the difference should be trivial, but I think it's good practice not to let myself decide that 🙂 |
r-n-o
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
TL;DR: developers with working cargo credentials may accidentally publish confidential Turnkey code/artifacts without additional chances to abort if cargo publish is run in the wrong context, since crates default to being publishable.
See rust-lang/cargo#6153 for potential impact if
publish = falseis not set.How I Tested These Changes
No functional change outside of cargo expected.
Pre merge check list
There is likely no CHANGELOG.md entry necessary.