Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax unrecoverable error; Release v0.3.0 #413

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Conversation

emostov
Copy link
Contributor

@emostov emostov commented Nov 27, 2023

Summary & Motivation (Problem vs. Solution)

Going into unrecoverable error makes things harder. We also need a new release

How I Tested These Changes

Existing test coverage

Pre merge check list

  • Update CHANGELOG.MD

@emostov emostov changed the title Don't delete ephemeral key and don't go into unrecoverable when get attestation doc fails Don't delete ephemeral key; Don't go into unrecoverable phase if inject_key or live_attestation_doc Nov 27, 2023
@emostov emostov marked this pull request as ready for review November 28, 2023 01:08
@emostov emostov force-pushed the zeke-no-unrecoverable-error branch from 7b629b2 to af7b40e Compare November 28, 2023 01:13
@emostov emostov changed the title Don't delete ephemeral key; Don't go into unrecoverable phase if inject_key or live_attestation_doc Don't delete ephemeral key; Relax unrecoverable error Nov 28, 2023
@emostov emostov force-pushed the zeke-no-unrecoverable-error branch from af7b40e to 3e0e1f3 Compare November 28, 2023 01:15
@emostov emostov changed the title Don't delete ephemeral key; Relax unrecoverable error Relax unrecoverable error Nov 28, 2023
@emostov emostov force-pushed the zeke-no-unrecoverable-error branch from 3e0e1f3 to beed1c0 Compare November 28, 2023 02:16
@emostov emostov force-pushed the zeke-no-unrecoverable-error branch from 49190aa to a424f10 Compare November 28, 2023 02:17
@emostov emostov changed the title Relax unrecoverable error Relax unrecoverable error; Release v0.3.0 Nov 28, 2023
@emostov emostov force-pushed the zeke-no-unrecoverable-error branch from eb94017 to 2ecaff4 Compare November 28, 2023 15:04
@emostov emostov force-pushed the zeke-no-unrecoverable-error branch from 2ecaff4 to b2a2ef2 Compare November 28, 2023 15:04
@emostov emostov merged commit 7d3f7ca into main Nov 28, 2023
17 checks passed
@emostov emostov deleted the zeke-no-unrecoverable-error branch November 28, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants