add executable arguments to spawn #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| args = args.slice(1); | ||
| args.unshift(local); | ||
|
|
||
| // add executable arguments to spawn | ||
| for (var i = 0; i < process.execArgv.length; i++) { |
There was a problem hiding this comment.
How about
args = process.execArgv.concat(args)
|
I'll wait for #290 and then implement a test case. |
zhiyelee
added a commit
to zhiyelee/commander.js
that referenced
this pull request
Apr 3, 2015
Merged
|
This PR is involved in #387 |
rrthomas
pushed a commit
to rrthomas/commander.js
that referenced
this pull request
Apr 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slight modification to inject node arguments into sub-commands. Specifically, I made it to allow the --harmony flag to perpetuate to sub-commands.
I'm not quite sure how to write a test for this as no tests exist to test the function as is. See: #290