Repeated options #198
Merged
Repeated options #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just thought of this, then I saw this pull request. 👍 |
| @@ -324,7 +324,7 @@ Command.prototype.option = function(flags, description, fn, defaultValue){ | |||
| // and conditionally invoke the callback | |||
| this.on(oname, function(val){ | |||
| // coercion | |||
| if (null != val && fn) val = fn(val); | |||
| if (null !== val && fn) val = fn(val, 'undefined' != typeof self[name] ? self[name] : defaultValue); | |||
There was a problem hiding this comment.
no need for typeof here, just undefined === or a hasOwnProperty
…t can be used to collect values.
|
Just fixed the undefined check you commented on. |
This was referenced Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit in
test.options.commands.jsfixes a test that was failing when I cloned the repo.The second commit allows to collect values through coercion functions by making the previous option value available to those functions. See the tests I have added and the examples in
examples/coercion.