Support for --cflags
style option parameters, unit test, fixes #174
#176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion already in #174, I removed the extra validation in required options so that they could handle cflag style option parameters. I also modified the
normalize()
function so that no additional normalization is performed on arguments following a require option. This accounts for a case like this:without adjusting the normalization code, that would be normalized to:
but with the changes in this pull request it is handled appropriately.
All unit tests, included the one I added for this particular scenario, pass.