Reconfigure standard and eslint (#1668)

* Add eslint-config-standard peer dependencies explicitly

* Remove unused eslint customisation, closer to standard

* Configure eslint with no-extra-semi, as per semistandard

* Use standard-with-typescript again now installing dependencies

* Fix linting for undefined property

* Run js and rs lint by default for `npm run lint`

.eslintrc.js

@@ -6,10 +6,10 @@ const javascriptSettings = {
   ],
   rules: {
     'no-else-return': ['error', { allowElseIf: false }],
-    'no-var': 'warn',
-    'one-var': 'off',
     'space-before-function-paren': ['error', 'never'],
-    semi: ['error', 'always']
+    // manual "semistandard" settings
+    semi: ['error', 'always'],
+    'no-extra-semi': 'error'
   }
 };
 
@@ -22,17 +22,12 @@ const typescriptSettings = {
     '@typescript-eslint'
   ],
   extends: [
-    'eslint:recommended',
-    'plugin:@typescript-eslint/eslint-recommended',
-    'plugin:@typescript-eslint/recommended'
+    'standard-with-typescript'
   ],
   rules: {
     'no-else-return': ['error', { allowElseIf: false }],
-    'no-var': 'warn',
-    'one-var': 'off',
-    'space-before-function-paren': ['error', 'never'],
-    semi: 'off',
-    '@typescript-eslint/semi': ['error', 'always'],
+    'space-before-function-paren': 'off',
+    '@typescript-eslint/space-before-function-paren': ['error', 'never'],
     '@typescript-eslint/member-delimiter-style': [
       'error',
       {
@@ -46,9 +41,11 @@ const typescriptSettings = {
         }
       }
     ],
-    // Add some "standard" rules by hand, as eslint-config-standard-with-typescript painful to keep up to date
-    quotes: ['error', 'single'],
-    'no-trailing-spaces': 'error'
+    // manual "semistandard" settings
+    semi: 'off',
+    '@typescript-eslint/semi': ['error', 'always'],
+    'no-extra-semi': 'off',
+    '@typescript-eslint/no-extra-semi': ['error']
   }
 };
 

lib/argument.js

@@ -49,7 +49,7 @@ class Argument {
 
   name() {
     return this._name;
-  };
+  }
 
   /**
    * @api private
@@ -75,7 +75,7 @@ class Argument {
     this.defaultValue = value;
     this.defaultValueDescription = description;
     return this;
-  };
+  }
 
   /**
    * Set the custom handler for processing CLI command arguments into argument values.
@@ -87,7 +87,7 @@ class Argument {
   argParser(fn) {
     this.parseArg = fn;
     return this;
-  };
+  }
 
   /**
    * Only allow argument value to be one of choices.
@@ -108,7 +108,7 @@ class Argument {
       return arg;
     };
     return this;
-  };
+  }
 
   /**
    * Make argument required.