Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/resolve bug fetching more history #1176

Merged
merged 16 commits into from
May 26, 2023
Merged

fix/resolve bug fetching more history #1176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9aea2ea
Added missing changes and modified dist assets.
actions-user May 25, 2023
bb8dcf1
Added missing changes and modified dist assets.
actions-user May 25, 2023
f8cf3da
fix: resolve bug fetching more history
jackton1 May 26, 2023
d23006e
Merge f8cf3da781459fe784aa19e33b3aea70a7675c1a into 77f872a7594af6375…
jackton1 May 26, 2023
61f6255
Added missing changes and modified dist assets.
actions-user May 26, 2023
c2c3210
Fixed bug comparing changes.
jackton1 May 26, 2023
c356d18
Merge c2c3210790588b684d1f5f574fc492df009d161b into 77f872a7594af6375…
jackton1 May 26, 2023
0e70ab0
Added missing changes and modified dist assets.
actions-user May 26, 2023
94d85e9
Updated to use Math.max
jackton1 May 26, 2023
30aaf01
updated silent config
jackton1 May 26, 2023
a1a679b
Merge 30aaf0184564d8435a91e7cb5b1bd841bbec7099 into 77f872a7594af6375…
jackton1 May 26, 2023
3076679
Added missing changes and modified dist assets.
actions-user May 26, 2023
2974ed6
Remove invalid input
jackton1 May 26, 2023
3dff319
Update log level
jackton1 May 26, 2023
29f26ea
Merge 3dff3193dc7ddda547d8cc16e2520b46a76099fd into 77f872a7594af6375…
jackton1 May 26, 2023
0c14162
Added missing changes and modified dist assets.
actions-user May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,16 +689,16 @@ jobs:
echo '${{ toJSON(steps.changed-files-json.outputs.all_changed_files) }}'
shell:
bash
- name: Run changed-files with json raw format
id: changed-files-json-raw-format
- name: Run changed-files with json unescaped format
id: changed-files-json-unescaped
uses: ./
with:
json: true
json_raw_format: true
escape_json: false
- name: Show output
run: |
echo '${{ toJSON(steps.changed-files-json-raw-format.outputs) }}'
echo '${{ toJSON(steps.changed-files-json-raw-format.outputs.all_changed_files) }}'
echo '${{ toJSON(steps.changed-files-json-unescaped.outputs) }}'
echo '${{ toJSON(steps.changed-files-json-unescaped.outputs.all_changed_files) }}'
shell:
bash
- name: Run changed-files with comma separator
Expand Down
54 changes: 30 additions & 24 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

21 changes: 15 additions & 6 deletions src/commitSha.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export const getSHAForPushEvent = async (
}

await verifyCommitSha({sha: previousSha, cwd: workingDirectory})
core.info(`Previous SHA: ${previousSha}`)
core.debug(`Previous SHA: ${previousSha}`)

return {
previousSha,
Expand Down Expand Up @@ -177,10 +177,6 @@ export const getSHAForPushEvent = async (
core.debug('Getting previous SHA for last remote commit...')
if (env.GITHUB_EVENT_FORCED === 'false' || !env.GITHUB_EVENT_FORCED) {
previousSha = env.GITHUB_EVENT_BEFORE
} else {
previousSha = await getParentSha({
cwd: workingDirectory
})
}

if (
Expand All @@ -190,6 +186,19 @@ export const getSHAForPushEvent = async (
previousSha = await getParentSha({
cwd: workingDirectory
})
} else if (
(await verifyCommitSha({
sha: previousSha,
cwd: workingDirectory,
showAsErrorMessage: false
})) !== 0
) {
core.warning(
`Previous commit ${previousSha} is not valid. Using parent commit.`
)
previousSha = await getParentSha({
cwd: workingDirectory
})
}

if (previousSha === currentSha) {
Expand Down Expand Up @@ -322,7 +331,7 @@ export const getSHAForPullRequestEvent = async (
}

await verifyCommitSha({sha: currentSha, cwd: workingDirectory})
core.info(`Previous SHA: ${previousSha}`)
core.debug(`Previous SHA: ${previousSha}`)

return {
previousSha,
Expand Down
1 change: 1 addition & 0 deletions src/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export const getEnv = async (): Promise<Env> => {
if (eventPath) {
eventJson = JSON.parse(await fs.readFile(eventPath, {encoding: 'utf8'}))
}
core.debug(`Env: ${JSON.stringify(process.env, null, 2)}`)
core.debug(`Event: ${JSON.stringify(eventJson, null, 2)}`)

return {
Expand Down
2 changes: 1 addition & 1 deletion src/inputs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export const getInputs = (): Inputs => {
}

if (fetchDepth) {
inputs.fetchDepth = parseInt(fetchDepth, 10)
inputs.fetchDepth = Math.max(parseInt(fetchDepth, 10), 2)
}

if (dirNamesMaxDepth) {
Expand Down
Loading