this is abouth 1212m emu patch

[oeai]

one of the biggest problems is that the firmware was not loaded
i've moved emu1010_init out of function - load_patches so it was clear
and now it's 1275 line that was missed before, and some other changes i'll probably will commentout if needed

[tiwai]

At Sat, 05 Jan 2013 11:42:29 -0800,
Ra wrote:

one of the biggest problems is that the firmware was not loaded
i've moved emu1010_init out of function - load_patches so it was clear
and now it's 1275 line that was missed before, and some other changes i'll probably will commentout if needed

I don't accept any pull requests from github. It's provided just as a
mirror of kernel.org repo.

Please follow the standard procedure of patch submission described in
Documentation/SubmittingPatches.

BTW, about your changes:
through a quick glance, it seems that it can break other
emu10k1/emu20k1 devices. Please fix the patch so that you are 100%
sure that it doesn't break any other devices.

Also, follow the coding style described in the document above.
scripts/checkpatch.pl is your friend.

For further questions / comments, please post to alsa-devel ML.

thanks,

Takashi

You can merge this Pull Request by running:

git pull https://github.com/oeai/sound patch-1

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

• this is abouth 1212m emu patch

-- File Changes --

M sound/pci/emu10k1/emu10k1_main.c (322)

-- Patch Links --

https://github.com/tiwai/sound/pull/1.patch
https://github.com/tiwai/sound/pull/1.diff

[oeai]

Sorry, i don't have much time for programming right now, i did what i
can - i'm not a C++ programmer, for me it was not working with latest
snapshot and i've changed it as i can.
and for the pull request - it's just simplier for you to work with it i
thought
and i just made a fork for emu1212m users and pointed to you that you
got an error for just emu1212 - it is not loading firmware really and i
described where's the catch out.
and this is made for those who works on sources and knows what to do,
maybe i'll get back to it in a later time, but i'm doing other projects
as well finding more and more bugs, but actually i need to work on some
really other projects instead but it is all bugged...
and i was posting in ML really but some messages just didn't appear and
this patch i've posted too.
i've created a separated project for this, so i can comment it and work on it
easier, maybe someone will join me and help to change it more accurately
https://github.com/oeai/emu1212m-alsa-driver
i will comment some changes i've made so you can see the difference
that is not so hard really
gl

btw right now
you are missing this code in emu10k1_main.c torvalds#862 string

err = snd_emu1010_load_firmware(emu);

if (err != 0) {

snd_printk(

 KERN_INFO "emu1010: Loading Firmware file %s failed\n",

 filename);

return err;

}