Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to format amount .toString() and value conversions for Amounts #19

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

Walledgarden
Copy link
Collaborator

No description provided.

@Walledgarden Walledgarden added the enhancement New feature or request label Apr 24, 2023
@Walledgarden Walledgarden self-assigned this Apr 24, 2023
@Walledgarden Walledgarden linked an issue Apr 24, 2023 that may be closed by this pull request
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 24, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d89eabe
Status: ✅  Deploy successful!
Preview URL: https://0692a4a1.tipcc-js.pages.dev
Branch Preview URL: https://3-format-amount.tipcc-js.pages.dev

View logs

@ZeroWave022 ZeroWave022 self-requested a review April 24, 2023 18:08
@ZeroWave022
Copy link
Contributor

ZeroWave022 commented Apr 24, 2023

TipccClient is getting too long, with too functions and sometimes unnecessary variables.
After this PR, an issue will be opened to rewrite these functions into managers, so the Client will become less chaotic.

@Walledgarden Walledgarden merged commit 81358da into main Apr 24, 2023
@Walledgarden Walledgarden deleted the 3-format-amount branch April 24, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format Amount
2 participants