Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to current chromedp. #1540

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Dec 22, 2020

They've added a new argument to WaitFunc, which I've just decided to ignore, as it seems to work without using it for anything.

@aykevl
Copy link
Member

aykevl commented Jan 18, 2021

Can you please run go mod tidy to clean up go.sum?
If that doesn't work, you can try adding an (empty) go.mod file to some directories (src, llvm-project, llvm-build, build, lib). That is a way to make the Go toolchain ignore those directories (they will be considered a new module).

Other than that it looks reasonable. Pinging @bradleypeabody in case he wants to comment on it.

@bradleypeabody
Copy link
Contributor

It looks like the latest tag on the chromedp project is v0.6.4.

This PR is using v0.5.4.

@QuLogic Is there any reason not to upgrade to the latest version? If not, I think that would best.

@QuLogic
Copy link
Contributor Author

QuLogic commented Jan 18, 2021

Can you please run go mod tidy to clean up go.sum?

I did; it doesn't really ever delete anything.

@QuLogic Is there any reason not to upgrade to the latest version? If not, I think that would best.

It was simply not the latest version at the time.

@bradleypeabody
Copy link
Contributor

Cool, LGTM.

I suspect the extra go.sum entries are due to this: golang/go#33008. I suggest not worrying about it for now and let it get cleaned up later with Go 1.16.

@deadprogram
Copy link
Member

Thanks for this contribution @QuLogic and thanks @bradleypeabody for reviewing.

Now merging.

@deadprogram deadprogram merged commit 5642d72 into tinygo-org:dev Jan 24, 2021
@QuLogic QuLogic deleted the update-chromedp branch January 24, 2021 23:35
@aykevl aykevl mentioned this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants