[breaking change] Rework the server creation API #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| @@ -25,7 +25,7 @@ fn get_content_type(path: &Path) -> &'static str { | |||
|
|
|||
| fn main() { | |||
| use ascii::AsciiCast; | |||
| let server = tiny_http::ServerBuilder::new().with_random_port().build().unwrap(); | |||
| let server = tiny_http::Server::http("0.0.0.0:0").unwrap(); | |||
There was a problem hiding this comment.
I know that you didn't change the functionality of this example, but could you change this to not use a random port? It could be the case that the port is less than 1024, which requires super user privileges (at least on unix machines), which could cause the test to fail.
5b12ce8 to
0021e43
Compare
frewsxcv
added a commit
that referenced
this pull request
Nov 24, 2015
[breaking change] Rework the server creation API
|
Thanks! Want me to publish a new version or wait for your other PR? |
|
Wait for the SSL stuff maybe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #101
Fix #104
The
ToSocketAddrtrait is specially conceived to be passed toTcpListener::bind, so we should use it directly.Also, the port 0 seems to be a standard for "a random available port", so there's no need for the
with_random_portfunction anymore.I went with a public
ServerConfigin order to make things explicit. This struct can be extended in the future with things such asclient_timeout,ssl(cc #11) ormax_clients(cc #26). Users are encouraged to callhttpinstead ofnew.Note that I removed the
client_timeoutparameter because I noticed it was unused anyway.