Change reference object in Job's to a specialized MachineRef #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ObjectRefernce used by Job's is too broad as it contains fields relating to FieldPaths, Groups, API Versions and more that aren't required for Machine object reference. Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
ce23203 to
4009476
Compare
jacobweinstock
approved these changes
Dec 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
=======================================
Coverage 59.50% 59.50%
=======================================
Files 4 4
Lines 321 321
=======================================
Hits 191 191
Misses 97 97
Partials 33 33
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ObjectRefernce used by Job's is too broad as it contains fields relating to FieldPaths, Groups, API Versions and more that aren't required for Machine object reference.
This was proposed by <enter name> some time ago and we never implemented it.