Adding ipmi port to BaseboardManagement type #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aravind Ramalingam <ramaliar@amazon.com>
micahhausler
suggested changes
May 17, 2022
| @@ -64,6 +64,10 @@ type Connection struct { | |||
| // +kubebuilder:validation:MinLength=1 | |||
| Host string `json:"host"` | |||
|
|
|||
| // Port is the IPMI port of the BaseboardManagement. | |||
There was a problem hiding this comment.
nit: this could be HTTP/Redfish, can you make this wording generic? Can you state what a default value is, if any?
There was a problem hiding this comment.
I think default would be 623. I can set a kubebuilder:default
| @@ -64,6 +64,10 @@ type Connection struct { | |||
| // +kubebuilder:validation:MinLength=1 | |||
| Host string `json:"host"` | |||
|
|
|||
| // Port is the IPMI port of the BaseboardManagement. | |||
| // +kubebuilder:validation:MinLength=1 | |||
| Port string `json:"port"` | |||
There was a problem hiding this comment.
I kept it as string because bmclib expects port as a string. But we can change it to int if that makes more sense 👍
Signed-off-by: Aravind Ramalingam <ramaliar@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #4 +/- ##
=======================================
Coverage 54.46% 54.46%
=======================================
Files 4 4
Lines 112 112
=======================================
Hits 61 61
Misses 42 42
Partials 9 9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aravind Ramalingam ramaliar@amazon.com
Description
Added Port to
BaseboardManagement.Spec.Connection. Port represents the IPMI port of the BMC.Why is this needed
Removes port hardcoding to default IPMI UDP port
623