Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseboardManagement controller to readonly #10

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

pokearu
Copy link
Contributor

@pokearu pokearu commented Jun 5, 2022

Description

Changes convert BaseboardManagement controller to only fetch the current power status of the machine BMC.
Also removed pause annotation as they are unused.

Why is this needed

This enforces the actions only from BMCJobs, this prevents overlap in state between BaseboardManagement controller and BMCJobs.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

pokearu added 2 commits June 5, 2022 01:16
Signed-off-by: Aravind Ramalingam <ramaliar@amazon.com>
Signed-off-by: Aravind Ramalingam <ramaliar@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #10 (d08c61e) into main (4dc2085) will decrease coverage by 0.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   21.45%   20.78%   -0.67%     
==========================================
  Files           4        4              
  Lines         289      279      -10     
==========================================
- Hits           62       58       -4     
+ Misses        219      215       -4     
+ Partials        8        6       -2     
Impacted Files Coverage Δ
controllers/baseboardmanagement_controller.go 74.35% <100.00%> (+3.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dc2085...d08c61e. Read the comment docs.

@chrisdoherty4 chrisdoherty4 merged commit 599b740 into tinkerbell:main Jun 6, 2022
@pokearu pokearu mentioned this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants