Clean up: #186
Merged
Clean up: #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6abb3e to
527cee0
Compare
| @@ -6,5 +6,7 @@ MACHINE1_MAC=08:00:27:9e:f5:3a | |||
|
|
|||
| # https://github.com/tinkerbell/charts/pkgs/container/charts%2Fstack | |||
| HELM_CHART_VERSION=0.4.3 | |||
| KUBECTL_VERSION=1.28.3 | |||
| KUBECTL_VERSION=1.27.12 | |||
There was a problem hiding this comment.
Should we even have a .env here? Should it be .env.example?
There was a problem hiding this comment.
yeah, because the k3d version is actually 1.27.
There was a problem hiding this comment.
the .env is not an example. its used when we run vagrant up.
There was a problem hiding this comment.
Right, but do we expect it to change from 1 env to the other? That's typically how .env is used.
There was a problem hiding this comment.
yes and no. users can change these values but the name doesnt have any particular significance. its just a file to hold values. We could change it.
chrisdoherty4
approved these changes
Apr 16, 2024
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
## Description Remove references to sandbox. Update versions for helm, k3d, etc. Update template images to use latest as quay.io/tinkerbell/actions/ don't have tags. ## Why is this needed Fixes: # ## How Has This Been Tested? ## How are existing users impacted? What migration steps/scripts do we need? ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove references to sandbox. Update versions for helm, k3d, etc. Update template images to use latest as quay.io/tinkerbell/actions/ don't have tags.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: