Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test GitHub Action #105

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Conversation

tylerjw
Copy link
Collaborator

@tylerjw tylerjw commented Mar 28, 2021

Fixes #104

This is an attempt to fix the various CI errors.

@tylerjw
Copy link
Collaborator Author

tylerjw commented Mar 28, 2021

I don't understand why the test.yml action didn't run. Do you know why it isn't running?

@tylerjw
Copy link
Collaborator Author

tylerjw commented Mar 28, 2021

Closing and re-opening to see if I can trigger the test workflow. (discovered it was manually disabled through github ui, enabled it to try to test this).

@tylerjw tylerjw closed this Mar 28, 2021
@tylerjw tylerjw reopened this Mar 28, 2021
@tylerjw
Copy link
Collaborator Author

tylerjw commented Mar 28, 2021

@tylerjw tylerjw changed the title Add DISPLAY env to test action Fix Test GitHub Action Mar 28, 2021
@tylerjw tylerjw force-pushed the test-workaround branch 3 times, most recently from 9f2ad2d to 3c3739d Compare March 28, 2021 16:42
@tylerjw tylerjw requested a review from dodgyrabbit March 28, 2021 16:47
@tylerjw tylerjw force-pushed the test-workaround branch 4 times, most recently from d6198d8 to edd7af5 Compare March 28, 2021 16:57
@tylerjw
Copy link
Collaborator Author

tylerjw commented Mar 28, 2021

Ok, I think this is good. I'm not sure what to do about the travis error on MacOS. I added a poetry cache to the github action as that seems to speed up the poetry install.

The issue with travis seems to be that the project requires a minimum of python 3.8 and that's not available on the MacOS runner version used by the travis run. Maybe there is a newer version of the runner we could use, or maybe we could use python 3.7?

@dodgyrabbit
Copy link
Collaborator

discovered it was manually disabled through github ui

Yes, figured we won't want to use up unecessary Github Action minutes if it's known to be failing.

I added a poetry cache to the github action as that seems to speed up the poetry install.

Great, thanks.

I'm not sure what to do about the travis error on MacOS

I had to figure out a bunch of things here by myself, so some of this info may be incorrect:

  • This project uses some kind of cookie-cutter templating system, probably because @timothycrosley has a lot of different projects to maintain.
  • There is a tool called "cruft" that updates a project, based on main template. Presumably, the goal is to update the main template and then all his smaller projects update themselves based on the newer template. I could not readily find the source code for cruft.
  • When this project was originally created, Travis was the CI tool of choice.
  • Github has subsequently released github actions, which has a free tier and makes CI possible without Travis
  • When I reviewed what this cruft thingy does, I saw it pulls against https://github.com/timothycrosley/cookiecutter-python.
  • That template now uses github actions.

So ultimately I think we can completely deprecate Travis and just let this github action do it's thing. There may be some more nuanced things - like better support for headless, OSX and so forth. However, for now my thinking is focus on the Linux community anyways, since you can use the Elgato version on OSX and Windows (even though this could all work there too).

@dodgyrabbit dodgyrabbit merged commit 523a392 into timothycrosley:master Mar 28, 2021
@tylerjw tylerjw deleted the test-workaround branch March 28, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix github action
2 participants