-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Test GitHub Action #105
Conversation
I don't understand why the |
Closing and re-opening to see if I can trigger the test workflow. (discovered it was manually disabled through github ui, enabled it to try to test this). |
Try again, this time using https://github.com/marketplace/actions/gabrielbb-xvfb-action |
9f2ad2d
to
3c3739d
Compare
d6198d8
to
edd7af5
Compare
edd7af5
to
685975c
Compare
Ok, I think this is good. I'm not sure what to do about the travis error on MacOS. I added a poetry cache to the github action as that seems to speed up the The issue with travis seems to be that the project requires a minimum of python 3.8 and that's not available on the MacOS runner version used by the travis run. Maybe there is a newer version of the runner we could use, or maybe we could use python 3.7? |
Yes, figured we won't want to use up unecessary Github Action minutes if it's known to be failing.
Great, thanks.
I had to figure out a bunch of things here by myself, so some of this info may be incorrect:
So ultimately I think we can completely deprecate Travis and just let this github action do it's thing. There may be some more nuanced things - like better support for headless, OSX and so forth. However, for now my thinking is focus on the Linux community anyways, since you can use the Elgato version on OSX and Windows (even though this could all work there too). |
Fixes #104
This is an attempt to fix the various CI errors.