Skip to content
This repository has been archived by the owner on Aug 24, 2019. It is now read-only.

Commit

Permalink
Merge pull request #5 from timolehto/feat/remove-cache
Browse files Browse the repository at this point in the history
Feat/remove cache
  • Loading branch information
timolehto authored Apr 13, 2017
2 parents eecb12b + 1f293ec commit e755a54
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 13 deletions.
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
DEPRECATED, OBSOLET, UNMAINTAINED
=======================
Bundler has had support for specifying any build configs via envs for a while now and all of this is fully supported with heroku so there is no need to use this buildpack anymore. See this heroku article for more information:
https://devcenter.heroku.com/articles/bundler-configuration#gem-build-configuration-settings

Also apparently caching is nolonger supported the way it used to be and may be causing problems for users (as per this issue:
https://github.com/timolehto/heroku-bundle-config/issues/4). So I've simply removed those lines. I haven't been using this buildpack for anything for a long time and can't be bothered to really test this change... anyhow pls don't use this anymore. There will be no more commits to this repo.

Heroku buildpack: Heroku Bundle Config
=======================

Expand Down
11 changes: 0 additions & 11 deletions bin/compile
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
#pwd contains this buildpack
build_dir="$1" #Contains the rails application, as it was checked out from GIT
#E.g. /tmp/build_d237f460-a947-4e42-a7e1-61a3abcc27b6
cache_dir="$2" #Contains the cahde dir. All the cached files are there and this
#or any later buildpacks may use it to fetch data.
#/app/tmp/cache

#What does the /app folder containt, the old app?

Expand All @@ -24,8 +21,6 @@ cache_dir="$2" #Contains the cahde dir. All the cached files are there and this

echo "Old .bundle/config contents"
cat "$build_dir/.bundle/config"
echo "Cache .bundle/config contents"
cat "$cache_dir/.bundle/config"

echo "Purging .bundle folder if present"
[ -d "$build_dir/.bundle" ] && rm -rf "$build_dir/.bundle"
Expand All @@ -43,10 +38,4 @@ echo "Convert all aboslute path references in the bundle to refer the temporary
find "$build_dir/.bundle/" -type f -exec sed -i "s /app/ $build_dir/ g" {} \;
#sed "s /app/ /$build_dir/ g" "$build_dir/.bundle/*"

echo "Purging .bundle folder if present from cache as well"
[ -d "$cache_dir/.bundle" ] && rm -rf "$cache_dir/.bundle"
echo "Caching the changes.."
mkdir -p "$cache_dir"
cp -r "$build_dir/.bundle" "$cache_dir/.bundle"

#sed: can't read /tmp/build_c982f0d9-9b66-42e6-a875-0a681a1e47fb/.bundle/*: No such file or directory
4 changes: 2 additions & 2 deletions bin/detect
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
#!/bin/sh

echo 'WARNING YOU ARE USING DEPRECATED, OBSOLETE, UNMAINTANED BUILDPACK heroku-bundle-config!!!'
# this pack is valid for apps with a .heroku-bundle directory in the root
if [ -d "$1/.heroku-bundle" ]; then
echo "Heroku Bundle Config"
exit 0
else
echo "This app is not valid for Heroku Bundle Config buidpack."
exit 1
fi
fi

0 comments on commit e755a54

Please sign in to comment.