Add thumbs up reaction #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jetersen
commented
Aug 10, 2022
•
- Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- Ensure that the pull request title represents the desired changelog entry
- Please describe what you did
- Link to relevant issues in GitHub or Jira
- Link to relevant pull requests, esp. upstream and downstream changes
- Ensure you have provided tests - that demonstrates feature works or fixes the issue
jetersen
commented
Aug 10, 2022
app/router.js
Outdated
| : await reportError(authToken, payload.issue.node_id, result.error); | ||
| await (result.enabled | ||
| ? Promise.all([ | ||
| addReaction(authToken, payload.issue.comment.node_id, "THUMBS_UP"), |
There was a problem hiding this comment.
Oh wait we are adding a comment for each commands recognized.
Perhaps we just do thumbs up whether it is enabled or not to show that we received the command.
timja
reviewed
Aug 11, 2022
| ? await command.run(authToken) | ||
| : await reportError(authToken, payload.issue.node_id, result.error); | ||
| try { | ||
| await addReaction(authToken, payload.comment.node_id, "THUMBS_UP"); |
There was a problem hiding this comment.
you had an extra level of nesting here under issue which didn't exist.
Gave a nice excuse to add error handling though :)
timja
approved these changes
Aug 11, 2022
|
Changed it to not error if reaction failed in #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.