-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make @showprogress support keyword arguments #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! has been on my mind for a while 😁
It also (I think) should allow run-time disabling of progress with enabled=false
kwarg.
I do think it needs tests to make sure that there aren't any wacky edge cases with for instance kwargs and positional args interleaved.
Ha I see now that that was the original feature request! |
This allows constructs such as: ``` @showprogress "X: " color=:red for x in 1:10 sleep(1) end ``` and ``` @showprogress showspeed=true for x in 1:10 sleep(1) end ```
I added some tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow the tests didn't run, I'll close and reopen.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 95.53% 96.56% +1.03%
==========================================
Files 1 1
Lines 515 524 +9
==========================================
+ Hits 492 506 +14
+ Misses 23 18 -5
☔ View full report in Codecov by Sentry. |
This allows constructs such as:
and
Fixes #229.