Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging of Slight.Alexa #3

Closed
1 of 5 tasks
Silvenga opened this issue Jan 4, 2017 · 21 comments
Closed
1 of 5 tasks

Merging of Slight.Alexa #3

Silvenga opened this issue Jan 4, 2017 · 21 comments

Comments

@Silvenga
Copy link

Silvenga commented Jan 4, 2017

How would you feel about moving the rest of Slight.Alexa to this project?

From the Slight.Alexa project:

  • Project base
  • Basic tests from sample responses
  • Combined .Net 4.5 + .NetStandard 1.2 support (upgrade to 1.6?)
  • Project icon
  • Re-adding of XML docs
@timheuer
Copy link
Owner

timheuer commented Jan 4, 2017

Yeah, let's do this! A few comments:

  • .NET Standard vs. .NET Core -- I'm curious why you think .NET Standard is better here?
  • Project Icon -- I'd like to see something more generic (or none at all really, but the feather doesn't make sense to me :-))
  • XML Docs -- I was going to start newer comments that hopefully would drive support for readthedocs.org

@Silvenga
Copy link
Author

Silvenga commented Jan 4, 2017

.NET Standard vs. .NET Core -- I'm curious why you think .NET Standard is better here?

As .NetStandard is the most portable profile for interoperability between .Net runtimes. .NetCore is very far from a replacement of .NetFull and it still does not work fully under Mono. With the project being under .NetStandard (compatible as a PCL library) we can use existing tooling and environments.

Project Icon -- I'd like to see something more generic (or none at all really, but the feather doesn't make sense to me :-))

It's a quill. I added that as the name "Alexa" comes from the Great Library of Alexandria. The icon doesn't need to represent anything, we can create meaning - Alexa is already an abstract ideal anyway. e.g. https://github.com/Fody/Fody

XML Docs -- I was going to start newer comments that hopefully would drive support for readthedocs.org

What system did you have in mind?

@jaddie
Copy link

jaddie commented Jan 5, 2017

.NetStandard

No version of .Net works fully under Mono as it is incomplete, hence why its proving hard work making Umbraco work on it, however making the Umbraco.Core run cross platform has been achieved rather easily and it works as expected on .NetCore on Linux. I would lean on the side of building on top of .NetCore as the framework but support .NetStandard as the standard & any issues with it running on Linux etc be raised at the appropriate locations since the target of Microsoft is now to make it work entirely as expected cross-platform, it is essentially the next level replacement & therefore if building something new which could be rather underpinning as a library then it should be as future-proof as possible by considering the big picture :)

Project Icon

Ah I see, thats new to me haha, I was in the same group as Tim & though it was a feather or something didn't really pay it much attention, why not make it something similar to what Amazon might already have for their services? They must have a media pack as well anyway

Documentation

I agree, readthedocs is nicely readable and usable :)

@Silvenga
Copy link
Author

Silvenga commented Jan 5, 2017

@jaddie

I would lean on the side of building on top of .NetCore

That would disregard 99% of the .Net ecosystem. .NetStandard is the replacement of the PCL's which run under the .NetCore and .NetFull runtimes.

From https://github.com/dotnet/standard/blob/master/docs/faq.md:

.NET Standard is a set of APIs that all .NET platforms have to implement. This unifies the .NET platforms and prevents future fragmentation.
.NET Standard 2.0 will be implemented by .NET Framework, .NET Core, and Xamarin. For .NET Core, this will add many of the existing APIs that have been requested.
.NET Standard 2.0 includes a compatibility shim for .NET Framework binaries, significantly increasing the set of libraries that you can reference from your .NET Standard libraries.
.NET Standard will replace Portable Class Libraries (PCLs) as the tooling story for building multi-platform .NET libraries.

@timheuer
Copy link
Owner

timheuer commented Jan 5, 2017

I talked with my counterparts on the .NET team and now agree with @Silvenga :-) -- let's move to .NET Standard (I think my project here is already on that based on the project.json) but some of the naming in the tooling is still a bit confusing for me. Let's do it!

@Silvenga
Copy link
Author

Silvenga commented Jan 8, 2017

@timheuer see #4 for tests and project normalization.

@jaddie
Copy link

jaddie commented Jan 8, 2017

Woops, I'm sorry I had my wires crossed haha, I agree actually, was thinking about them the wrong way round!

@bjorg
Copy link

bjorg commented Mar 28, 2017

Could you publish also a .NET Core 1.0.x compatible version? Otherwise, it cannot be used in C# for AWS Lambda, which only supports .NET Core LTS.

@Silvenga
Copy link
Author

I'm kind of waiting for tooling support at this point. Even with VS2017 out tooling support is a little sporadic, I don't even know if VSCode works with the new .csproj format (with the deprecation of project.json and xproj).

@bjorg
Copy link

bjorg commented Mar 28, 2017 via email

@timheuer
Copy link
Owner

It targets .NET Standard 1.6 which is compatible with .NET Core 1.0 -- https://github.com/dotnet/standard/blob/master/docs/versions.md

@bjorg
Copy link

bjorg commented Mar 28, 2017 via email

@timheuer
Copy link
Owner

@bjorg can you tell me what type of project is HandleAlexaPrompts.csproj and what version of dotnet CLI you are using?

@bjorg
Copy link

bjorg commented Mar 28, 2017 via email

@timheuer
Copy link
Owner

Hmm this should be working but I am getting the error now too -- talking with my colleagues on .NET team to see what's up. Stay tuned.

@timheuer
Copy link
Owner

Adding the direct version works @bjorg:

dotnet add package Alexa.NET -v 1.0.0-beta-5 

@timheuer
Copy link
Owner

FYI @bjorg we logged a bug on the dotnet CLI: https://github.com/dotnet/cli/issues/6176

@bjorg
Copy link

bjorg commented Mar 28, 2017 via email

@timheuer
Copy link
Owner

No problem @bjorg -- this looks like a bug in how NuGet resolves things so it was a good find. I was banging my head on the false error message :-)

@terrajobst
Copy link

The permanent home of the bug is: NuGet/Home#4699

timheuer pushed a commit that referenced this issue Jun 27, 2017
@jaddie
Copy link

jaddie commented Jun 8, 2019

This one is done as well? Although it was a good discussion about the reasoning around things, I've also edited my response in the conversation to resolve the reason for confusion, .NetStandard all the way, perhaps we should preserve this in the docs or a readme level file & close this issue?

@timheuer timheuer closed this as completed Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants