-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging of Slight.Alexa #3
Comments
Yeah, let's do this! A few comments:
|
As .NetStandard is the most portable profile for interoperability between .Net runtimes. .NetCore is very far from a replacement of .NetFull and it still does not work fully under Mono. With the project being under .NetStandard (compatible as a PCL library) we can use existing tooling and environments.
It's a quill. I added that as the name "Alexa" comes from the Great Library of Alexandria. The icon doesn't need to represent anything, we can create meaning - Alexa is already an abstract ideal anyway. e.g. https://github.com/Fody/Fody
What system did you have in mind? |
No version of .Net works fully under Mono as it is incomplete, hence why its proving hard work making Umbraco work on it, however making the Umbraco.Core run cross platform has been achieved rather easily and it works as expected on .NetCore on Linux. I would lean on the side of building on top of .NetCore as the framework but support .NetStandard as the standard & any issues with it running on Linux etc be raised at the appropriate locations since the target of Microsoft is now to make it work entirely as expected cross-platform, it is essentially the next level replacement & therefore if building something new which could be rather underpinning as a library then it should be as future-proof as possible by considering the big picture :)
Ah I see, thats new to me haha, I was in the same group as Tim & though it was a feather or something didn't really pay it much attention, why not make it something similar to what Amazon might already have for their services? They must have a media pack as well anyway
I agree, readthedocs is nicely readable and usable :) |
That would disregard 99% of the .Net ecosystem. .NetStandard is the replacement of the PCL's which run under the .NetCore and .NetFull runtimes. From https://github.com/dotnet/standard/blob/master/docs/faq.md:
|
I talked with my counterparts on the .NET team and now agree with @Silvenga :-) -- let's move to .NET Standard (I think my project here is already on that based on the project.json) but some of the naming in the tooling is still a bit confusing for me. Let's do it! |
Woops, I'm sorry I had my wires crossed haha, I agree actually, was thinking about them the wrong way round! |
Could you publish also a .NET Core 1.0.x compatible version? Otherwise, it cannot be used in C# for AWS Lambda, which only supports .NET Core LTS. |
I'm kind of waiting for tooling support at this point. Even with VS2017 out tooling support is a little sporadic, I don't even know if VSCode works with the new .csproj format (with the deprecation of project.json and xproj). |
It works great in vscode and from the new `dotnet` CLI. However, because it was compiled for .Net Standard 1.2, I had to import it as a folder instead of a package for my .Net Core project. Really great library, by the way, works like a charm and saved me hours from manually mapping the Alexa skills myself!
If there’s interest, I can look into how to make the solution compatible with multiple frameworks.
|
It targets .NET Standard 1.6 which is compatible with .NET Core 1.0 -- https://github.com/dotnet/standard/blob/master/docs/versions.md |
Hmm. Well nuget doesn’t resolve it. Here’s what I get:
dotnet add package Alexa.NET
Microsoft (R) Build Engine version 15.1.548.43366
Copyright (C) Microsoft Corporation. All rights reserved.
Writing /var/folders/4b/7t6zwfj88xl5rq008k8xjhqr0000gq/T/tmp7gM7gX.tmp
info : Adding PackageReference for package 'Alexa.NET' into project '/HandleAlexaPrompts.csproj'.
log : Restoring packages for /HandleAlexaPrompts.csproj...
info : GET https://api.nuget.org/v3-flatcontainer/alexa.net/index.json
info : OK https://api.nuget.org/v3-flatcontainer/alexa.net/index.json 369ms
error: Unable to resolve 'Alexa.NET' for '.NETCoreApp,Version=v1.0'.
error: Package 'Alexa.NET' is incompatible with 'all' frameworks in project '/HandleAlexaPrompts.csproj’.
|
@bjorg can you tell me what type of project is HandleAlexaPrompts.csproj and what version of dotnet CLI you are using? |
For dotnet:
~> dotnet
Microsoft .NET Core Shared Framework Host
Version : 1.1.0
Build : 928f77c4bc3f49d892459992fb6e1d5542cb5e86
For dotnet CLI:
~> dotnet --version
1.0.1
For the .csproj file:
~> cat HandleAlexaPrompts.csproj
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp1.0</TargetFramework>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Amazon.Lambda.Core" Version="1.0.0" />
<PackageReference Include="Amazon.Lambda.Serialization.Json" Version="1.0.1" />
<PackageReference Include="Newtonsoft.Json" Version="10.0.1" />
</ItemGroup>
<ItemGroup>
<DotNetCliToolReference Include="Amazon.Lambda.Tools" Version="1.4.0" />
</ItemGroup>
</Project>
|
Hmm this should be working but I am getting the error now too -- talking with my colleagues on .NET team to see what's up. Stay tuned. |
Adding the direct version works @bjorg:
|
FYI @bjorg we logged a bug on the dotnet CLI: https://github.com/dotnet/cli/issues/6176 |
Woohoo! That’s awesome! Thanks for helping me out and not squishing me like a puny bug for my false conclusions! :)
|
No problem @bjorg -- this looks like a bug in how NuGet resolves things so it was a good find. I was banging my head on the false error message :-) |
The permanent home of the bug is: NuGet/Home#4699 |
This one is done as well? Although it was a good discussion about the reasoning around things, I've also edited my response in the conversation to resolve the reason for confusion, .NetStandard all the way, perhaps we should preserve this in the docs or a readme level file & close this issue? |
How would you feel about moving the rest of Slight.Alexa to this project?
From the Slight.Alexa project:
The text was updated successfully, but these errors were encountered: