Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I wonder why only 'Nor' is displayed in dls.show_batch(sharvey=True). #416

Closed
DongHyukHwang opened this issue Mar 3, 2022 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@DongHyukHwang
Copy link

I'm running https://colab.research.google.com/github/timeseriesAI/tsai/blob/master/tutorial_nbs/01a_MultiClass_MultiLabel_TSClassification.ipynb line by line.

I am using the latest version of tsai 0.3.0.
In the middle of following each line, you can see that all of my result screens are displayed as 'Nor' in the

Visualize data
dls.show_batch(sharey=True) part.

You can see that the 'ROT' value is also mixed in the web page. I wonder why this issue occurred.

@oguiza oguiza added the bug Something isn't working label Mar 8, 2022
@oguiza
Copy link
Contributor

oguiza commented Mar 8, 2022

Hi @DongHyukHwang,
Thanks for creating this issue. It's actually kind of a bug in the code.
I'll explain. In order to speed up training, some array-like structures (like zarr) require samples to be sorted. Sorting is implemented within each batch. But there's a downside. If the samples in the dataset are sorted by class, only the first class/es will be displayed. I've flagged this as a bug and will see how it can be fixed.

oguiza pushed a commit that referenced this issue Mar 21, 2022
@oguiza
Copy link
Contributor

oguiza commented Mar 21, 2022

Hi @DongHyukHwang,
I've already fixed the code in GitHub. It'd be good if you could test that show_batch works well now.
You'll need to pip install using:

pip install git+https://github.com/timeseriesAI/tsai.git

@DongHyukHwang
Copy link
Author

Error

@DongHyukHwang
Copy link
Author

Could you change the encoding to cp949?

@oguiza
Copy link
Contributor

oguiza commented Apr 20, 2022

This seems to be a new issue unrelated to the original one. If it still persists, please create a new issue.

@oguiza oguiza closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants