Support ALTER COLUMN SET NOT NULL on compressed chunks #7707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c54f8c to
c8f79c7
Compare
c8f79c7 to
526fe82
Compare
antekresic
approved these changes
Feb 13, 2025
526fe82 to
b01ab38
Compare
akuzm
reviewed
Feb 13, 2025
src/process_utility.c
Outdated
|
|
||
| initStringInfo(&command); | ||
| appendStringInfo(&command, | ||
| "SELECT EXISTS(SELECT FROM %s.%s WHERE %s IS NULL", |
There was a problem hiding this comment.
When the compressed column has a null value, it means a default, so probably shouldn't be an OR.
There was a problem hiding this comment.
we also just found out it's not true, and we can't distinguish missing from default on the sql level..
akuzm
approved these changes
Feb 13, 2025
b01ab38 to
2c89ec5
Compare
This patch adds support for ALTER TABLE ALTER COLUMN SET NOT NULL to compressed chunks. The statement will be allowed when no NULL values for the specific column are present in compressed chunks.
2c89ec5 to
f7bc2fe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7707 +/- ##
==========================================
+ Coverage 80.06% 81.95% +1.88%
==========================================
Files 190 246 +56
Lines 37181 45116 +7935
Branches 9450 11254 +1804
==========================================
+ Hits 29770 36976 +7206
- Misses 2997 3726 +729
Partials 4414 4414 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for ALTER TABLE ALTER COLUMN SET NOT NULL
to compressed chunks. The statement will be allowed when no NULL
values for the specific column are present in compressed chunks.