This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Improve logging of active servers on start. #1217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com
Description
Fixes: #1182
This PR improves the logging of Promscale on the start.
The logs now will be
Note: This PR adds
run.Group
(fromgithub.com/oklog/run
) that is used to manage the lifecycle of goroutines, which is a library used in Prometheus. This allows us to stop the execution even on partial error, which earlier was not being done.TODO
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: