Microfsexp #18
Merged
Microfsexp #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request timcanham#17 from gjwatney/microfsexp
bocchino
reviewed
May 29, 2023
| @@ -99,8 +99,10 @@ struct MicroFsBin { | |||
|
|
|||
| struct MicroFsConfig { | |||
| FwNativeUIntType numBins; //!< The number of bins configured. Must be <= than MAX_MICROFS_BINS | |||
| FwNativeUIntType filler; //!< filler bytes to ensure 8 byte alignment of this data structure | |||
There was a problem hiding this comment.
There are several issues here:
- This code seems to assume that
sizeof(FwNativeUnitType) == 4. We can't assume that. FwNativeUintType does not have a defined architecture-independent size. - We should not be using FwNativeUintType anyway. It doesn't have a defined size.
- A better way to ensure alignment in C++11 is to use alignas. If you can't use alignas for some reason, then you can write
U8 pad[4]for example to add padding of 4 bytes.
There was a problem hiding this comment.
I'm going to merge it to my fork to get the other changes, then we'll deal with the alignment and native integer issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
A description of the changes contained in the PR.
Rationale
A rationale for this change. e.g. fixes bug, or most projects need XYZ feature.
Testing/Review Recommendations
Fill in testing procedures, specific items to focus on for review, or other info to help the team verify these changes are flight-quality.
Future Work
Note any additional work that will be done relating to this issue.