refactor and fix, bump to version 1.1.4

tim-hub · Jul 25, 2022 · 4659ec5 · 4659ec5
1 parent 6434ca9
commit 4659ec5
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 9 deletions.
diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
 	"id": "obsidian-bible-reference",
 	"name": "Bible Reference",
-	"version": "1.1.3",
+	"version": "1.1.4",
 	"minAppVersion": "0.12.0",
 	"description": "Taking Bible Study note in Obsidian.md application easily. Automatically suggesting Bible Verses as references. ",
 	"author": "tim-hub",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "obsidian-bible-reference",
-	"version": "1.1.3",
+	"version": "1.1.4",
 	"description": "Taking Bible Study note in Obsidian.md application easily. Automatically suggesting Bible Verses as references. ",
 	"main": "main.js",
 	"scripts": {

diff --git a/src/provider/BibleAPIDotComProvider.ts b/src/provider/BibleAPIDotComProvider.ts
@@ -20,7 +20,7 @@ export class BibleAPIDotComProvider extends BibleProvider {
   public buildRequestURL(
     bookName: string,
     chapter: number,
-    verses?: number[],
+    verses: number[],
     versionName?: string,
   ): string {
     let queryString = `${bookName}+${chapter}:`;

diff --git a/src/provider/BibleAPIFactory.ts b/src/provider/BibleAPIFactory.ts
@@ -43,7 +43,7 @@ export class BibleAPIFactory {
         return new BollyLifeProvider(bibleVersion);
       }
       default: {
-        return null;
+        return new BibleAPIDotComProvider(bibleVersion);
       }
     }
   }

diff --git a/src/provider/BibleProvider.ts b/src/provider/BibleProvider.ts
@@ -3,8 +3,8 @@ import { IVerse } from '../interfaces/IVerse';
 export abstract class BibleProvider {
   protected _key: string; // the version selected
   protected _apiUrl: string;
-  protected _queryUrl?: string;
-  protected _bibleReferenceHead?: string;
+  protected _queryUrl: string;
+  protected _bibleReferenceHead: string;
 
   /**
    * Get the Key Identity for the Bible version
@@ -39,7 +39,7 @@ export abstract class BibleProvider {
   public async query(
     bookName: string,
     chapter: number,
-    verse?: number[],
+    verse: number[],
     versionName?: string,
   ): Promise<IVerse[]> {
     if ((!this._key) && versionName) {

diff --git a/src/provider/BollyLifeProvider.ts b/src/provider/BollyLifeProvider.ts
@@ -25,7 +25,7 @@ export class BollyLifeProvider extends BibleProvider {
   ): string {
     const baseUrl = this._chapterApiUrl;
     const book = Reference.bookIdFromName(bookName);
-    this._queryUrl = `${baseUrl}/${versionName.toUpperCase()}/${book}/${chapter}/`;
+    this._queryUrl = `${baseUrl}/${versionName?.toUpperCase()}/${book}/${chapter}/`;
     return this._queryUrl;
   }
 

diff --git a/versions.json b/versions.json
@@ -13,5 +13,6 @@
 	"1.1.0": "0.12.0",
 	"1.1.1": "0.12.0",
 	"1.1.2": "0.12.0",
-	"1.1.3": "0.12.0"
+	"1.1.3": "0.12.0",
+	"1.1.4": "0.12.0"
 }