Wrote test cases for version regex

tim-hub · Dec 4, 2024 · 430a6fb · 430a6fb
1 parent 60f38d5
commit 430a6fb
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/src/utils/reg.test.ts b/src/utils/reg.test.ts
@@ -1,4 +1,4 @@
-import { BOOK_REG, MODAL_REG } from './regs'
+import { BOOK_REG, MODAL_REG, VERSION_REG } from './regs'
 
 describe('test book name reg matching in different languages', () => {
   test('should match book name in English', () => {
@@ -74,4 +74,23 @@ describe('test modal reg matching in different languages', () => {
     const reg = new RegExp(MODAL_REG)
     expect(reg.test(modal)).toBe(false)
   })
+
+  test('should match version with only alphabets', () => {
+    const modal = '-niv2011'
+    const reg = new RegExp(VERSION_REG)
+    expect(reg.test(modal)).toBe(true)
+  })
+
+  test('should match version with numbers', () => {
+    const modal = '-niv2011'
+    const reg = new RegExp(VERSION_REG)
+    expect(reg.test(modal)).toBe(true)
+  })
+
+  test('should not match when there is hyphen', () => {
+    const modal = '-should-fail'
+    const reg = new RegExp(MODAL_REG)
+    expect(reg.test(modal)).toBe(false)
+  })
+
 })
diff --git a/src/utils/regs.ts b/src/utils/regs.ts
@@ -11,7 +11,7 @@ export const MODAL_REG = /([123])*\s*([\p{L}[\\\]^_`a-zA-Z]{2,100}|\p{Script=Han
 
 export const BOOK_REG = /([123])*\s*([\p{L}[\\\]^_`a-zA-Z]{2,100}|\p{Script=Han}{1,})/isu
 
-export const VERSION_REG = /(-[a-zA-Z0-9-]+)$/isu
+export const VERSION_REG = /(-[a-zA-Z0-9]+)$/isu
 
 // export const BOOK_REG = /[123]*\s*[A-Z\[\\\]^_`a-z]{2,}/