require firewall permission at install for node.exe - fixes #1200 (re…

…lies on local copy of nsis firewall plugin)

platforms/windows/installer/nsis_script.nsi

@@ -1,4 +1,4 @@
-; Script generated by the HM NIS Edit Script Wizard.
+; TileMill nsis installer script
 
 ; HM NIS Edit Wizard helper defines
 !define PRODUCT_NAME "TileMill"
@@ -9,6 +9,12 @@
 !define PRODUCT_UNINST_ROOT_KEY "HKLM"
 !define PRODUCT_STARTMENU_REGVAL "NSIS:StartMenuDir"
 
+; firewall extras
+!addplugindir "nsisFirewall"
+!include "FileFunc.nsh"
+
+RequestExecutionLevel admin
+
 ; MUI 1.67 compatible ------
 !include "MUI.nsh"
 
@@ -61,6 +67,16 @@ Section "MainSection" SEC01
 
 SectionEnd
 
+; Add firewall rule
+Section "Add Windows Firewall Rule"
+	; Add TileMill to the authorized list
+	nsisFirewall::AddAuthorizedApplication "$INSTDIR\node.exe" "Evented I/O for V8 JavaScript"
+	Pop $0
+	IntCmp $0 0 +3
+		MessageBox MB_OK "A problem happened while adding Node.exe (used by TileMill) to the Firewall exception list (result=$0)"
+		Return
+SectionEnd
+
 Section -AdditionalIcons
   SetOutPath $INSTDIR
   !insertmacro MUI_STARTMENU_WRITE_BEGIN Application
@@ -71,7 +87,7 @@ Section -AdditionalIcons
 	  SW_SHOWNORMAL \
       ALT|CONTROL|t "TileMill"
 
-  CreateShortCut "$SMPROGRAMS\$ICONS_GROUP\Uninstall.lnk" "$INSTDIR\Uninstall-TileMill.exe"
+  CreateShortCut "$SMPROGRAMS\$ICONS_GROUP\Uninstall TileMill.lnk" "$INSTDIR\Uninstall-TileMill.exe"
   !insertmacro MUI_STARTMENU_WRITE_END
 SectionEnd
 
@@ -96,12 +112,20 @@ Function un.onInit
 FunctionEnd
 
 Section Uninstall
+   SetShellVarContext all
+   ; Remove Node.js from the authorized list
+   nsisFirewall::RemoveAuthorizedApplication "$INSTDIR\node.exe"
+   Pop $0
+   IntCmp $0 0 +3
+       MessageBox MB_OK "A problem happened while removing Node.exe (used by TileMill) from the Firewall exception list (result=$0)"
+       Return
+
   Delete "$INSTDIR\Uninstall-TileMill.exe"
   RMDir /r "$INSTDIR\*.*"
   RMDir "$INSTDIR"
   !insertmacro MUI_STARTMENU_WRITE_BEGIN Application
   !insertmacro MUI_STARTMENU_GETFOLDER "Application" $ICONS_GROUP
-  Delete "$SMPROGRAMS\$ICONS_GROUP\Uninstall.lnk"
+  Delete "$SMPROGRAMS\$ICONS_GROUP\Uninstall TileMill.lnk"
   Delete "$SMPROGRAMS\$ICONS_GROUP\Start TileMill.lnk"
   RMDir /r "$SMPROGRAMS\$ICONS_GROUP"
   !insertmacro MUI_STARTMENU_WRITE_END