Ensure initial transition can be aborted then retried. #213
Conversation
cf8a0b7 to
f1a83bf
Compare
f1a83bf to
7ba0712
Compare
When the initial transition is aborted and subsequently retried, the `urlMethod` of `null` was being inherited. This meant that upon retry, the URL would never be updated.
|
@alexspeller @cibernox - This fixes emberjs/ember.js#15190 (if y'all are curious to the root cause). |
| // inherited for a new transition because then | ||
| // the url would not update even though it should | ||
| if (this.urlMethod !== null) { | ||
| newTransition.method(this.urlMethod); |
There was a problem hiding this comment.
I'm a bit confused actually. I thought that the urlMethod could be either update or replace. Under what circumstances is it null?
There was a problem hiding this comment.
@cibernox - It is null only for the very first initial transition. The reason for this, is that the browser has already updated the window.location and we are basically just telling the system to update its internal state to match the current URL. The docs for Router#handleURL explain it a bit also.
There was a problem hiding this comment.
FWIW, I think it may be better to just add another flag for this to the Transition object. That way the urlMethod doesn't need to play double duty, and its much more obvious what is going on...
Attempting to recreate the scenario identified in emberjs/ember.js#15190.