Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MetisAPI): match *data_source_ids* to *data_sources* #49

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

blokhin
Copy link
Member

@blokhin blokhin commented Feb 12, 2024

Finally with this we should be able to do client.v0.collections.create(**metis_collection_changed)

@blokhin blokhin added the enhancement New feature or request label Feb 12, 2024
@blokhin blokhin requested a review from knopki February 12, 2024 15:14
@blokhin
Copy link
Member Author

blokhin commented Feb 12, 2024

NB at the BFF, the dataSourceIds refer to the tables fields, whereas the dataSources refer to the DTOs

Copy link
Member

@knopki knopki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blokhin blokhin merged commit c41bb99 into master Feb 12, 2024
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix_data_source_ids branch February 12, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants