Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support running ctl command with custom file system #231

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Jun 23, 2022

Signed-off-by: tabokie xy.tao@outlook.com

Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie tabokie requested a review from Connor1996 June 23, 2022 07:40
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #231 (9b799e0) into master (07dcadb) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   97.18%   97.19%   +0.01%     
==========================================
  Files          30       30              
  Lines        9368     9368              
==========================================
+ Hits         9104     9105       +1     
+ Misses        264      263       -1     
Impacted Files Coverage Δ
src/codec.rs 98.67% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07dcadb...9b799e0. Read the comment docs.

@tabokie
Copy link
Member Author

tabokie commented Jun 28, 2022

Ping @Connor1996

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabokie tabokie merged commit 7a436ea into tikv:master Jun 28, 2022
@tabokie tabokie deleted the ctl-with-fs branch June 28, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants