Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/http: add func for jenkins test #7516

Merged
merged 7 commits into from
Dec 13, 2023

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Dec 11, 2023

What problem does this PR solve?

Issue Number: Ref #7300

What is changed and how does it work?

Check List

Tests

  • Integration test

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 11, 2023
@HuSharp HuSharp requested a review from JmPotato December 11, 2023 03:47
@ti-chi-bot ti-chi-bot bot requested a review from nolouch December 11, 2023 03:47
@HuSharp HuSharp requested review from rleungx and removed request for nolouch December 11, 2023 03:47
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 11, 2023
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #7516 (586738b) into master (f71de23) will decrease coverage by 0.01%.
The diff coverage is 72.97%.

❗ Current head 586738b differs from pull request most recent head ceaf18b. Consider uploading reports for the commit ceaf18b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7516      +/-   ##
==========================================
- Coverage   74.52%   74.51%   -0.01%     
==========================================
  Files         453      453              
  Lines       50042    50075      +33     
==========================================
+ Hits        37292    37313      +21     
- Misses       9414     9421       +7     
- Partials     3336     3341       +5     
Flag Coverage Δ
unittests 74.51% <72.97%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp HuSharp force-pushed the add_http_client_api_for_jenkins branch from 6293951 to 7d8316d Compare December 11, 2023 07:27
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the add_http_client_api_for_jenkins branch from 8d68ac0 to 38daa87 Compare December 12, 2023 05:33
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 12, 2023
@HuSharp HuSharp requested a review from lhy1024 December 13, 2023 03:11
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Member Author

HuSharp commented Dec 13, 2023

@JmPotato @lhy1024 can you leave a merge label? thx! :)

@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 586738b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 13, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2023

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 1eed494 into tikv:master Dec 13, 2023
@HuSharp HuSharp deleted the add_http_client_api_for_jenkins branch December 13, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants