-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctl: pd-ctl cmd will work well in char device mode #4479
Conversation
Signed-off-by: bufferflies <1045931706@qq.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add a test for it?
Signed-off-by: bufferflies <1045931706@qq.com>
I think it should need. |
Codecov Report
@@ Coverage Diff @@
## master #4479 +/- ##
==========================================
- Coverage 75.04% 74.91% -0.14%
==========================================
Files 264 264
Lines 27931 27937 +6
==========================================
- Hits 20961 20929 -32
- Misses 5119 5145 +26
- Partials 1851 1863 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: bufferflies <1045931706@qq.com>
92a1497
to
8ef5d44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM.
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: ead512e
|
@bufferflies: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
* pd-ctl cmd will work well in crontab && close 4478 Signed-off-by: bufferflies <1045931706@qq.com> * add unit test && close tikv#4478 Signed-off-by: bufferflies <1045931706@qq.com> * string nil and add return Signed-off-by: bufferflies <1045931706@qq.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
What problem does this PR solve?
close #4478
What is changed and how it works?
String split mention If s does not contain sep and sep is not empty, Split returns a
slice of length 1 whose only element is s. It will add args if the arg is nil in char device mode.
So it needs to check the args is nil.
Check List
Tests
Code changes
Side effects
Related changes
Release note