-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix race in hot region config #4167
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #4167 +/- ##
==========================================
+ Coverage 74.59% 74.63% +0.03%
==========================================
Files 260 260
Lines 26479 26481 +2
==========================================
+ Hits 19753 19764 +11
+ Misses 4945 4940 -5
+ Partials 1781 1777 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Ryan Leung <rleungx@gmail.com>
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 962cace
|
In response to a cherrypick label: new pull request created: #4170. |
Signed-off-by: HunDunDM <hundundm@gmail.com>
* fix race in hot region config Signed-off-by: Ryan Leung <rleungx@gmail.com> * address the comment Signed-off-by: Ryan Leung <rleungx@gmail.com> Signed-off-by: hzh0425 <642256541@qq.com>
What problem does this PR solve?
Close #4159.
What is changed and how it works?
Use the lock correctly.
Check List
Tests
Release note