Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.*: remove some unnecessary replaces #3553

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Mar 31, 2021

Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

Remove some unnecessary replaces in go.mod.

What is changed and how it works?

  • Replacing github.com/oleiade/reflections and github.com/sirupsen/logrus is due to some related go module bugs, such as Git commit overwritten causes builds to fail oleiade/reflections#14. Now the problems have gone, I think we should remove them.
  • Replacing go.etcd.io/bbolt is due to that we want to update bbolt independently while keeping the etcd version the same, so I keep it here.

Check List

Tests

  • Unit test
  • Integration test

Release note

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato requested a review from rleungx March 31, 2021 09:55
@JmPotato JmPotato added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 31, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2021
@lhy1024
Copy link
Contributor

lhy1024 commented Mar 31, 2021

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2021
@JmPotato
Copy link
Member Author

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2021
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #3553 (cc81c93) into master (bc63de8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3553      +/-   ##
==========================================
- Coverage   74.61%   74.60%   -0.02%     
==========================================
  Files         245      245              
  Lines       24109    24109              
==========================================
- Hits        17990    17987       -3     
- Misses       4505     4508       +3     
  Partials     1614     1614              
Flag Coverage Δ
unittests 74.60% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/election/lease.go 94.91% <0.00%> (-1.70%) ⬇️
server/member/member.go 69.56% <0.00%> (-1.64%) ⬇️
server/server.go 71.68% <0.00%> (-0.61%) ⬇️
server/grpc_service.go 47.62% <0.00%> (-0.23%) ⬇️
client/client.go 72.24% <0.00%> (+0.13%) ⬆️
server/tso/allocator_manager.go 77.24% <0.00%> (+0.16%) ⬆️
server/election/leadership.go 87.05% <0.00%> (+1.17%) ⬆️
pkg/etcdutil/etcdutil.go 88.23% <0.00%> (+3.52%) ⬆️
pkg/tempurl/tempurl.go 60.00% <0.00%> (+15.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc63de8...cc81c93. Read the comment docs.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JmPotato
Copy link
Member Author

JmPotato commented Apr 1, 2021

/run-all-tests

@JmPotato
Copy link
Member Author

JmPotato commented Apr 1, 2021

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cc81c93

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2021
@ti-chi-bot ti-chi-bot merged commit 70f8a20 into tikv:master Apr 1, 2021
@JmPotato JmPotato deleted the remove_unnecessary_replcae branch April 1, 2021 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants