-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.*: remove some unnecessary replaces #3553
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge cancel |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3553 +/- ##
==========================================
- Coverage 74.61% 74.60% -0.02%
==========================================
Files 245 245
Lines 24109 24109
==========================================
- Hits 17990 17987 -3
- Misses 4505 4508 +3
Partials 1614 1614
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Kudos, SonarCloud Quality Gate passed! |
/run-all-tests |
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: cc81c93
|
Signed-off-by: JmPotato ghzpotato@gmail.com
What problem does this PR solve?
Remove some unnecessary replaces in
go.mod
.What is changed and how it works?
github.com/oleiade/reflections
andgithub.com/sirupsen/logrus
is due to some related go module bugs, such as Git commit overwritten causes builds to fail oleiade/reflections#14. Now the problems have gone, I think we should remove them.go.etcd.io/bbolt
is due to that we want to updatebbolt
independently while keeping theetcd
version the same, so I keep it here.Check List
Tests
Release note