Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #207] cdc: modify ticdc dockerfile for tikv-cdc #208

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

zeminzhou
Copy link
Contributor

Signed-off-by: zeminzhou zhouzemin@pingcap.com

What problem does this PR solve?

modify ticdc dockerfile for tikv-cdc

Issue Number: close #207

Problem Description: TBD

What is changed and how does it work?

modify ticdc dockerfile for tikv-cdc

Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@zeminzhou zeminzhou requested review from pingyu and haojinming August 19, 2022 08:38
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #208 (88c3d2f) into main (1d8847b) will increase coverage by 0.0410%.
The diff coverage is n/a.

❗ Current head 88c3d2f differs from pull request most recent head b5f229d. Consider uploading reports for the commit b5f229d to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##               main       #208        +/-   ##
================================================
+ Coverage   61.5926%   61.6337%   +0.0410%     
================================================
  Files           170        170                
  Lines         13763      13809        +46     
================================================
+ Hits           8477       8511        +34     
+ Misses         4661       4652         -9     
- Partials        625        646        +21     
Flag Coverage Δ
cdc 61.6337% <ø> (+0.0410%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdc/pkg/pdtime/acquirer.go 58.1395% <0.0000%> (-6.9768%) ⬇️
cdc/cdc/kv/client.go 83.8616% <0.0000%> (-2.1614%) ⬇️
cdc/pkg/orchestrator/etcd_worker.go 78.5714% <0.0000%> (-1.6807%) ⬇️
cdc/cdc/sorter/unified/merger.go 68.2847% <0.0000%> (-0.6473%) ⬇️
cdc/cdc/owner/status_provider.go 20.5882% <0.0000%> (+2.4064%) ⬆️
cdc/pkg/pipeline/pipeline.go 79.7101% <0.0000%> (+2.8985%) ⬆️
cdc/cdc/sorter/unified/file_backend.go 53.9473% <0.0000%> (+20.1754%) ⬆️

Copy link
Collaborator

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Suggest to add a merge CI (CI after PR merged) to automatically push a latest image to hub.pingcap.net later, for ease of future use.

Copy link
Contributor

@haojinming haojinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pingyu pingyu merged commit 1cb59c9 into tikv:main Aug 22, 2022
@zeminzhou zeminzhou deleted the fix-dockerfile branch August 23, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc: add tikv-cdc dockerfile
3 participants