-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #207] cdc: modify ticdc dockerfile for tikv-cdc #208
Conversation
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
================================================
+ Coverage 61.5926% 61.6337% +0.0410%
================================================
Files 170 170
Lines 13763 13809 +46
================================================
+ Hits 8477 8511 +34
+ Misses 4661 4652 -9
- Partials 625 646 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Suggest to add a merge CI (CI after PR merged) to automatically push a latest image to hub.pingcap.net
later, for ease of future use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: zeminzhou zhouzemin@pingcap.com
What problem does this PR solve?
modify ticdc dockerfile for tikv-cdc
Issue Number: close #207
Problem Description: TBD
What is changed and how does it work?
modify ticdc dockerfile for tikv-cdc