Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiKV BR Development Tasks #67

Closed
12 tasks done
pingyu opened this issue Mar 21, 2022 · 3 comments · Fixed by #70
Closed
12 tasks done

TiKV BR Development Tasks #67

pingyu opened this issue Mar 21, 2022 · 3 comments · Fixed by #70
Labels
status/stale

Comments

@pingyu
Copy link
Collaborator

pingyu commented Mar 21, 2022 •
edited
Loading

TiKV BR Development Tasks

Close: #66
RFC: tikv/rfcs#86

Tasks

Reference

TiKV components related to backup & restore:

  • components/backup: for backup
  • components/sst_importer: for restore
  • split_region interface: for pre-splitting regions before restore

Some merged PR related:
@pingyu
Copy link
Collaborator Author

pingyu commented Mar 21, 2022

@zz-jason @haojinming PTAL~

@zz-jason zz-jason mentioned this issue Mar 21, 2022
Merged
pingyu pushed a commit that referenced this issue Mar 21, 2022
@zz-jason
[to #67] fix gosec failure for BR (#68)
fed55bc 
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
This was referenced Mar 21, 2022
Merged
Merged
pingyu pushed a commit that referenced this issue Mar 22, 2022
@zz-jason
[fix #67] fix golangci-lint failures for TiKV BR (#70)
2b13212 
* [fix #67] fix golangci failures for TiKV BR

Signed-off-by: Jian Zhang <zjsariel@gmail.com>

* add workflow for BR related pull requests

Signed-off-by: Jian Zhang <zjsariel@gmail.com>

* remove unused scripts and source files

Signed-off-by: Jian Zhang <zjsariel@gmail.com>

* add ut to workflow

Signed-off-by: Jian Zhang <zjsariel@gmail.com>
@pingyu pingyu reopened this Mar 23, 2022
zz-jason added a commit that referenced this issue Mar 23, 2022
@zz-jason @pingyu
[to #67] remove unused function and dead code (#69)
9afacac 
Co-authored-by: Ping Yu <yuping@pingcap.com>
This was referenced Mar 28, 2022
Merged
Merged
pingyu added a commit to pingyu/tikv-migration that referenced this issue Mar 28, 2022
@pingyu
br: cherry pick tidb#32612 to fix rawkv backup failure
7bd1b08 
Issue Number: tikv#67

Signed-off-by: pingyu <yuping@pingcap.com>
@pingyu pingyu mentioned this issue Mar 28, 2022
Merged
zz-jason added a commit that referenced this issue Mar 29, 2022
@zz-jason
[to #67] remove unused code related to restore (#76)
2e47c60
@zz-jason zz-jason mentioned this issue Mar 30, 2022
Merged
zz-jason added a commit that referenced this issue Mar 30, 2022
@zz-jason
[to #67] remove unused code related to parser (#78)
69ddf53
@zz-jason zz-jason mentioned this issue Mar 30, 2022
Merged
zz-jason added a commit that referenced this issue Mar 31, 2022
@zz-jason
[to #67] clean Makefile (#80)
39029ef
@zz-jason zz-jason mentioned this issue Apr 2, 2022
Merged
pingyu pushed a commit that referenced this issue Apr 6, 2022
@zz-jason
[to #67] setup backup/restore integration test for rawkv (#82)
2d13a80 
* [to #67] setup backup/restore integration test for rawkv

Signed-off-by: Jian Zhang <zjsariel@gmail.com>

* add github action

Signed-off-by: Jian Zhang <zjsariel@gmail.com>
pingyu added a commit that referenced this issue Apr 6, 2022
@zz-jason @pingyu
[to#67] remove some unused code (#81)
160651a 
* [to #67] remove some unused code

Signed-off-by: Jian Zhang <zjsariel@gmail.com>

* remove web

Signed-off-by: Jian Zhang <zjsariel@gmail.com>

Co-authored-by: Ping Yu <yuping@pingcap.com>
@zz-jason zz-jason mentioned this issue Apr 6, 2022
Merged
zz-jason added a commit that referenced this issue Apr 13, 2022
@zz-jason
[to #67] support setting api version in br requests (#75)
6eaf03d
@zz-jason zz-jason mentioned this issue Apr 13, 2022
Merged
@haojinming haojinming mentioned this issue Apr 13, 2022
Merged
zz-jason added a commit that referenced this issue Apr 14, 2022
@zz-jason
[to #67] remove unnecessary codes (#84)
7183ede
pingyu added a commit that referenced this issue Apr 14, 2022
@pingyu
[to #67] fix rawkv backup failure (#77)
a5cb1a1 
* br: cherry pick tidb#32612 to fix rawkv backup failure

Issue Number: #67

Signed-off-by: pingyu <yuping@pingcap.com>

* revert unnecessary port change

Signed-off-by: pingyu <yuping@pingcap.com>

* migrate test logics from run.sh to run.py

Signed-off-by: pingyu <yuping@pingcap.com>

* temporarily disable old versions < 6.0

Signed-off-by: pingyu <yuping@pingcap.com>

* separate CI of 5.X versions

Signed-off-by: pingyu <yuping@pingcap.com>

* bugfix

Signed-off-by: pingyu <yuping@pingcap.com>

* bugfix

Signed-off-by: pingyu <yuping@pingcap.com>

* address comments

Signed-off-by: pingyu <yuping@pingcap.com>

* tiny fix

Signed-off-by: pingyu <yuping@pingcap.com>
@haojinming haojinming mentioned this issue Apr 21, 2022
Merged
pingyu pushed a commit that referenced this issue Apr 26, 2022
@haojinming
[to #67] BR backup&restore for apiv2 (#91)
e7e2f0b 
* fix backup&re store issue

Signed-off-by: haojinming <jinming.hao@pingcap.com>

fix issue

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* golang format

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* resolve parts of review comments

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* fix br integration test issue

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* fix br integration test issue

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* fix br integration test issue

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* fix br integration test issue

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* fix br integration test issue

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* add unit test for SplitRegion

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* add unit test for GetCurrentTiKVApiVersion

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* add unit test for RegionSplitter.Split

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* fix v1->v1 issue

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* add unit test for format func

Signed-off-by: haojinming <jinming.hao@pingcap.com>
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity.

@pingyu
Copy link
Collaborator Author

pingyu commented Apr 30, 2022

All sub tasks are done.

@pingyu pingyu closed this as completed Apr 30, 2022
pingyu pushed a commit that referenced this issue May 6, 2022
@haojinming
[to #67] init gc worker process for tikv (#85)
866913f 
* init tikv gc worker

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* clean debug log and address review comment

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* change module name and add golangci check

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* add unit test

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* add readme

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* add config file and unit test

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* resolve review comments

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* resolve review comments

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* resolve review comments

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* remove etcd endpoint from input

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* fix configure file discription

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* address review comments

Signed-off-by: haojinming <jinming.hao@pingcap.com>

* fix golang lint check

Signed-off-by: haojinming <jinming.hao@pingcap.com>
@pingyu pingyu mentioned this issue May 7, 2022
Closed
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix #67] fix golangci-lint failures for TiKV BR zz-jason/migration
1 participant
@pingyu