only enable warnings in CI

..and remove stale arch condition. Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
tikv · Feb 6, 2025 · 63fae55 · 63fae55
1 parent 8c926d5
commit 63fae55
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/jemalloc-ctl/src/macros.rs b/jemalloc-ctl/src/macros.rs
@@ -63,7 +63,6 @@ macro_rules! r {
 
             #[cfg(test)]
             #[test]
-            #[cfg(not(target_arch = "mips64el"))]
             #[allow(unused)]
             fn [<$id _read_test>]() {
                 match stringify!($id) {
@@ -112,7 +111,6 @@ macro_rules! w {
 
             #[cfg(test)]
             #[test]
-            #[cfg(not(target_arch = "mips64el"))]
             fn [<$id _write_test>]() {
                 match stringify!($id) {
                     "background_thread" |
@@ -161,7 +159,6 @@ macro_rules! u {
 
             #[cfg(test)]
             #[test]
-            #[cfg(not(target_arch = "mips64el"))]
             #[allow(unused)]
             fn [<$id _update_test>]() {
                 match stringify!($id) {

diff --git a/jemalloc-ctl/src/raw.rs b/jemalloc-ctl/src/raw.rs
@@ -385,7 +385,6 @@ union MaybeUninit<T: Copy> {
 mod tests {
     use super::*;
     #[test]
-    #[cfg(not(target_arch = "mips64el"))] // FIXME: SIGFPE
     fn test_ptr2str() {
         unsafe {
             //{ // This is undefined behavior:

diff --git a/jemalloc-sys/build.rs b/jemalloc-sys/build.rs
@@ -145,9 +145,12 @@ fn main() {
         println!("cargo:rustc-link-lib={}={}", kind, &stem[3..]);
         return;
     }
-    // Disable -Wextra warnings - jemalloc doesn't compile free of warnings with
-    // it enabled: https://github.com/jemalloc/jemalloc/issues/1196
-    let compiler = cc::Build::new().extra_warnings(false).get_compiler();
+    let mut build = cc::Build::new();
+    if env::var("JEMALLOC_SYS_RUN_JEMALLOC_TESTS").is_err() {
+        // Disable -Wall unless in CI.
+        build.warnings(false);
+    }
+    let compiler = build.get_compiler();
     let cflags = compiler
         .args()
         .iter()