add reset-submodule script #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Dec 2, 2017
| git submodule update --init third_party/boringssl | ||
| git submodule update --init third_party/cares/cares | ||
| git submodule update --init third_party/zlib | ||
| cd third_party/zlib |
siddontang
reviewed
Dec 2, 2017
| #!/usr/bin/env bash | ||
| git submodule update --init grpc-sys/grpc | ||
| cd grpc-sys/grpc | ||
| git submodule update --init third_party/boringssl |
There was a problem hiding this comment.
can we use git submodule update --init --recursive directly?
There was a problem hiding this comment.
Then many unused submodules get initialized, which can be slow and probably fail due to network censor.
|
does the script have the executive mode? |
|
Yes. |
|
LGTM |
|
PTAL @overvenus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So when switching branch/tag, we can cleanup workspace conveniently.