Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

randgen: add json test #105

Merged
merged 3 commits into from
Dec 28, 2019
Merged

randgen: add json test #105

merged 3 commits into from
Dec 28, 2019

Conversation

hawkingrei
Copy link
Member

Signed-off-by: Wangweizhen hawking.rei@gmail.com

use mariadb/randgen to generate this file. this file contains 1000 sql.

@hawkingrei hawkingrei changed the title randgen: add json test [WIP]randgen: add json test Dec 9, 2019
@hawkingrei hawkingrei changed the title [WIP]randgen: add json test randgen: add json test Dec 9, 2019
@hawkingrei
Copy link
Member Author

@breeswish PTAL

@breezewish
Copy link
Member

Good job!

  • Is it possible to add JSON fields in the schema?
  • The schema should be put in the prepare directory
  • Maybe it's better to only generate SELECT .. WHERE ... statements

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 24, 2019 •
edited
Loading

@breeswish Done. Only generate SELECT * FROM JSON_XXX.

Do i need to push the randgen file to PR. it take many time to complete it.

@breezewish
Copy link
Member

Good job! According to CI it is finished very quickly: https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_integration_copr_test/detail/tidb_ghpr_integration_copr_test/1270/pipeline/

However looks like JSON_LENGTH is commented out, does it contain some implementation mistakes?

@hawkingrei
Copy link
Member Author

hawkingrei commented Dec 25, 2019 •
edited
Loading

JSON_LENGTH is commented out because it will cause error Unknown signature: JsonLengthSig.but I will add the JSON_LENGTH with tikv/5916 merging

@hawkingrei
Copy link
Member Author

Adding JSON_LENGTH, then I can use tikv/5916 to test this pr.

@hawkingrei hawkingrei force-pushed the add_json_test branch 2 times, most recently from 8b357ec to cb1d5ee Compare December 25, 2019 06:27
@hawkingrei
randgen: add json test
013a9a8 
Signed-off-by: Wangweizhen <hawking.rei@gmail.com>
@hawkingrei
remove bad sql
b3d82f9 
Signed-off-by: Wangweizhen <hawking.rei@gmail.com>
@hawkingrei
Copy link
Member Author

@breeswish Add the JSON_LENGTH and tested by tikv/5916.

@hawkingrei
Copy link
Member Author

/run-all-tests

@hawkingrei
Copy link
Member Author

@breeswish tikv/5916 has merged. PTAL.

@hawkingrei hawkingrei mentioned this pull request Dec 27, 2019
Open
@breezewish
Copy link
Member

Cool!

breezewish
breezewish approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lonng @iosmanthus @sticnarf PTAL

@lonng lonng merged commit c143682 into tikv:master Dec 28, 2019
@hawkingrei hawkingrei deleted the add_json_test branch December 28, 2019 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkingrei @breezewish @lonng