Finer is_retry_request settings
#763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebc8ed0 to
f885bf9
Compare
…ermined errors Signed-off-by: ekexium <eke@fastmail.com>
f885bf9 to
9c1bb5d
Compare
|
@cfzjywxk @MyonKeminta PTAL |
MyonKeminta
reviewed
Apr 6, 2023
| return resp, err | ||
| func (s *RegionRequestSender) SendReq( | ||
| bo *retry.Backoffer, req *tikvrpc.Request, regionID RegionVerID, timeout time.Duration, | ||
| ) (*tikvrpc.Response, int, error) { |
There was a problem hiding this comment.
The new return value tryTimes will be zero when it succeeds without retrying, right? I think it sounds more like retryTimes 😕 Can you add to the comment above about what's the new return value's exact meaning?
Signed-off-by: ekexium <eke@fastmail.com>
MyonKeminta
approved these changes
Apr 7, 2023
cfzjywxk
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #762
Set
is_retry_requestonly for requests that is possible to have undermined errors.For example, prewrite requests that have only met
RegionErrorerrors will not set this flag.For reviewers: the format tool adjusts some unrelated code snippets. Please just ignore them.