[Metrics] Supply extra metrics to monitor the flows under prefer-leader mode.
#716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rLeader mode. Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
|
/retest |
|
@LykxSassinator is there anyone you prefer to review the PR? |
@tonyxuqqi PTAL, thx |
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>
tonyxuqqi
reviewed
Mar 10, 2023
tonyxuqqi
approved these changes
Mar 10, 2023
|
ping @disksing , PTAL, thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is used to supply extra necessary metrics for monitoring the dataflows under
prefer-leadermode, providing an intuitive understanding if the destination of dataflows meet the expectation.In this pr, the report of dataflows' statistics is batched and scheduled to call
prometheusAPI for better accessing performance.