update tidb dependency of integration tests & use go 1.19 #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ekexium <eke@fastmail.com>
c3ff94e to
03cd4bd
Compare
Signed-off-by: ekexium <eke@fastmail.com>
03cd4bd to
3d954d6
Compare
sticnarf
reviewed
Sep 2, 2022
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/tikv/client-go/v2 | |||
|
|
|||
| go 1.18 | |||
| go 1.19 | |||
There was a problem hiding this comment.
Can we keep it unchanged at least for the root go.mod? Now, the minimal supported go version for this library is still 1.18.
.github/workflows/test.yml
Outdated
| @@ -28,7 +28,7 @@ jobs: | |||
| - name: Set up Go | |||
| uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: 1.18 | |||
| go-version: 1.19 | |||
There was a problem hiding this comment.
Can we still use 1.18 for the unit tests of the library?
This reverts commit 3d954d6. Signed-off-by: ekexium <eke@fastmail.com>
7a40a70 to
ad6a6f2
Compare
Signed-off-by: ekexium <eke@fastmail.com>
ad6a6f2 to
41c68d3
Compare
|
CI seems extremely unstable even if I only changed go version for compatibility test. I don't know if it's related to go 1.19. |
sticnarf
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ekexium eke@fastmail.com