Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: update pd/client #554

Merged
merged 4 commits into from
Jul 25, 2022
Merged

go.mod: update pd/client #554

merged 4 commits into from
Jul 25, 2022

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Jul 25, 2022 •
edited
Loading

for issue pingcap/tidb#36505, it got an incorrect clusterID which be fixed by tikv/pd#5281, so need update pd/client for client-go and tidb-server

@Defined2014
go.mod: update pd/client
40e0a0e 
Signed-off-by: Hangjie Mo <mohangjie1995@gmail.com>
@Defined2014
go mod tidy
0b9f0ba 
Signed-off-by: Hangjie Mo <mohangjie1995@gmail.com>
@Defined2014
Copy link
Contributor Author

Defined2014 commented Jul 25, 2022 •
edited
Loading

/cc @you06 @sticnarf
PTAL~

@sticnarf
Copy link
Collaborator

CI fails complaining go.mod needs updating.

@Defined2014
update go.mod in it
d8ce266 
Signed-off-by: Hangjie Mo <mohangjie1995@gmail.com>
@Defined2014
Copy link
Contributor Author

CI fails complaining go.mod needs updating.

Done.

@you06
Copy link
Contributor

you06 commented Jul 25, 2022

Need to impl SplitAndScatterRegions for mock client in PD before this PR?

@Defined2014
fix test
f568e9d 
Signed-off-by: Hangjie Mo <mohangjie1995@gmail.com>
@Defined2014
Copy link
Contributor Author

Need to impl SplitAndScatterRegions for mock client in PD before this PR?

Updated.

@Defined2014
Copy link
Contributor Author

Defined2014 commented Jul 25, 2022 •
edited
Loading

@sticnarf @you06 PTAL.
I think tidb-compatibility test which depends on tidb master branch is not required. I'll update tidb repo later to fix test.

@sticnarf sticnarf merged commit 0cdc7c1 into tikv:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you06 you06 you06 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Defined2014 @sticnarf @you06