[RawKV] support checksum #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: haojinming <jinming.hao@pingcap.com>
Signed-off-by: haojinming <jinming.hao@pingcap.com>
iosmanthus
reviewed
Jun 2, 2022
rawkv/rawkv.go
Outdated
| // (startKey, endKey], you can write: | ||
| // `Scan(ctx, push(startKey, '\0'), push(endKey, '\0'), limit)`. | ||
| func (c *Client) Checksum(ctx context.Context, startKey, endKey []byte, options ...RawOption, | ||
| ) (crc64Xor, totalKvs, totalBytes uint64, err error) { |
There was a problem hiding this comment.
Prefer to use a struct to wrap all these infos.
iosmanthus
reviewed
Jun 2, 2022
rawkv/rawkv.go
Outdated
Comment on lines
509
to
511
| // If you want to exclude the startKey or include the endKey, push a '\0' to the key. For example, to scan | ||
| // (startKey, endKey], you can write: | ||
| // `Scan(ctx, push(startKey, '\0'), push(endKey, '\0'), limit)`. |
There was a problem hiding this comment.
Seem it's the comments from Scan.
There was a problem hiding this comment.
yes, they accept the same input parameters and has same constraint.
There was a problem hiding this comment.
Suggested change
| // If you want to exclude the startKey or include the endKey, push a '\0' to the key. For example, to scan | |
| // (startKey, endKey], you can write: | |
| // `Scan(ctx, push(startKey, '\0'), push(endKey, '\0'), limit)`. | |
| // Checksum do checksum of continuous kv pairs in range [startKey, endKey). | |
| // If endKey is empty, it means unbounded. | |
| // If you want to exclude the startKey or include the endKey, push a '\0' to the key. For example, to checksum | |
| // (startKey, endKey], you can write: | |
| // `Checksum(ctx, push(startKey, '\0'), push(endKey, '\0'), limit)`. |
Signed-off-by: haojinming <jinming.hao@pingcap.com>
Signed-off-by: haojinming <jinming.hao@pingcap.com>
disksing
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: haojinming jinming.hao@pingcap.com
Support
checksumin rawkv.Client.Fix issue #518