Fix the problem that adaptive update interval doesn't recovers back and there's too much logs about setting the config #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd there's too much logs about setting the config Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
crazycs520
approved these changes
Nov 19, 2024
cfzjywxk
approved these changes
Nov 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, crazycs520 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
MyonKeminta
added a commit
to MyonKeminta/client-go
that referenced
this pull request
Nov 19, 2024
…nd there's too much logs about setting the config (tikv#1502) Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
MyonKeminta
added a commit
to MyonKeminta/client-go
that referenced
this pull request
Dec 11, 2024
…nd there's too much logs about setting the config (tikv#1502) Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
ekexium
pushed a commit
to ekexium/client-go
that referenced
this pull request
Jan 7, 2025
…nd there's too much logs about setting the config (tikv#1502) Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
ekexium
pushed a commit
to ekexium/client-go
that referenced
this pull request
Jan 9, 2025
…nd there's too much logs about setting the config (tikv#1502) Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found and fixed these problems:
doUpdateclosure, andnextUpdateIntervalcalculates the value of recovering based on the last tick time, it causes the update interval unable to recover back.SetLowResolutionTimestampUpdateIntervalevery 30 seconds no matter whether the user changes it. After adding the log about changing the update interval, then there becomes too many logs.