Breaking change: Remove Python 2 support and stop using use_2to3 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setuptools 58 removed support for use_2to3 and Python 2 has been EOL for a while. This change makes this library Python 3 only.
|
Thanks very much! I will dig up my pypi credentials and get this published, but I'm about to spend some days up a mountain: just in case something unexpected happens I would rather do that when I'm back down and can fix any mistakes I might make quickly. If you didn't see this merged and published by 2021-09-17 please feel free to poke me, I can't see anything that should delay me so long. |
jiasli
reviewed
Sep 8, 2021
Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com>
|
Thanks @tikitu - we appreciate it :) Enjoy the time away! |
|
Thanks @jiasli for that suggestion - you're right , no point advertising legacy support |
jkasperkiewicz
approved these changes
Sep 9, 2021
jiasli
approved these changes
Sep 9, 2021
rfay
pushed a commit
to ddev/ddev
that referenced
this pull request
Sep 9, 2021
Fixes breaking readthedocs builds due to removal of Python 2 support in setuptools 58. PR: tikitu/jsmin#34
Guts
added a commit
to Guts/mkdocs-rss-plugin
that referenced
this pull request
Sep 10, 2021
tnurse18
added a commit
to WPI-LNL/lnldb
that referenced
this pull request
Sep 10, 2021
Fixes breaking readthedocs builds due to removal of Python 2 support in setuptools 58
GraemeWatt
added a commit
to HEPData/hepdata
that referenced
this pull request
Sep 15, 2021
* Fixes broken Read the Docs build until jsmin v3.0.0 is released. * Pin to a commit made in tikitu/jsmin#34
This was referenced Sep 15, 2021
1 task
3 tasks
Muirrum
pushed a commit
to Muirrum/lnldb
that referenced
this pull request
Sep 29, 2021
Fixes breaking readthedocs builds due to removal of Python 2 support in setuptools 58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33
Setuptools 58 removed support for use_2to3 and Python 2 has been EOL for
a while. This change makes this library Python 3 only.