Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Default to 443 for gRPC port #131

Merged
merged 1 commit into from
Sep 24, 2022
Merged

fix: Default to 443 for gRPC port #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion client/src/main/java/com/tigrisdata/db/client/config/TigrisConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ public int hashCode() {
/** Builder class for {@link TigrisConfiguration} */
public static final class Builder {

private final String baseURL;
private static final int DEFAULT_GRPC_PORT = 443;
private String baseURL;
private TigrisConfiguration.NetworkConfig network;
private TigrisConfiguration.AuthConfig authConfig;
private ObjectMapper objectMapper;
Expand Down Expand Up @@ -134,6 +135,9 @@ public Builder withAuthConfig(AuthConfig authConfig) {
}

public TigrisConfiguration build() {
if (!this.baseURL.contains(":")) {
this.baseURL = this.baseURL + ":" + DEFAULT_GRPC_PORT;
}
return new TigrisConfiguration(this);
}

Expand Down